Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.py closes #695 #696

Merged
merged 3 commits into from
May 2, 2019
Merged

Update client.py closes #695 #696

merged 3 commits into from
May 2, 2019

Conversation

josh-gree
Copy link
Contributor

@josh-gree josh-gree commented May 2, 2019

Show the options available in doc website output...

Closes #695

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Updates some of the doc strings so options are visible in the generated docs

Show the options available in doc website output...
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         127      127           
  Lines        6384     6384           
  Branches      677      677           
=======================================
  Hits         5979     5979           
  Misses        283      283           
  Partials      122      122
Impacted Files Coverage Δ
flowclient/flowclient/client.py 94.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92262e...17003f7. Read the comment docs.

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         127      127           
  Lines        6384     6384           
  Branches      677      677           
=======================================
  Hits         5979     5979           
  Misses        283      283           
  Partials      122      122
Impacted Files Coverage Δ
flowclient/flowclient/client.py 94.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92262e...26f4f3c. Read the comment docs.

@greenape greenape added bug Something isn't working docs Documentation issues FlowClient Issues related to FlowClient labels May 2, 2019
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for that. Changelog entry please, then good to. go. I think.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: josh-gree <[email protected]>
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy 👍

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label May 2, 2019
@mergify mergify bot merged commit e5ddecd into master May 2, 2019
@mergify mergify bot deleted the josh-gree-patch-1 branch May 2, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation issues FlowClient Issues related to FlowClient ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs not quite right for flowclient
2 participants