Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TotalLocationEvents 'interval' parameter #808

Merged
merged 3 commits into from
May 17, 2019

Conversation

jc-harrison
Copy link
Member

Closes #807

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Exposes the 'interval' parameter of TotalLocationEvents objects through the API (this parameter was already included in the API spec, but was not actually passed to the TotalLocationEvents object).

@jc-harrison jc-harrison added the FlowMachine Issues related to FlowMachine label May 17, 2019
Copy link
Contributor

@maxalbert maxalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

Just needs a changelog entry, then good to merge.

@maxalbert
Copy link
Contributor

(And one of the tests is failing because the query_id has changed.)

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         130      130           
  Lines        6521     6521           
  Branches      693      693           
=======================================
  Hits         6087     6087           
  Misses        315      315           
  Partials      119      119
Flag Coverage Δ
#flowapi_unit_tests 79.84% <ø> (ø) ⬆️
#flowauth_unit_tests 93.97% <ø> (ø) ⬆️
#flowclient_unit_tests 83.57% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 91.09% <ø> (ø) ⬆️
#integration_tests 60.02% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
...core/server/query_schemas/location_event_counts.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8587a3a...ec5b68f. Read the comment docs.

@maxalbert maxalbert added the ready-to-merge Label indicating a PR is OK to automerge label May 17, 2019
@mergify mergify bot merged commit 229783b into master May 17, 2019
@mergify mergify bot deleted the expose-total-location-events-interval branch May 17, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TotalLocationEvents 'interval' parameter is not exposed
2 participants