Display year, seconds, tz when creating tokens #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenape
added
enhancement
maxalbert
reviewed
Jun 4, 2019
| format="yyyy/MM/dd HH:mm:ss" | ||
| ampm={false} | ||
| margin="normal" | ||
| helperText={new Date().toTimeString().slice(9)} |
There was a problem hiding this comment.
Can we add a comment here that says this displays the timezone (which is not obvious otherwise)?
maxalbert
approved these changes
Jun 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 130 130
Lines 6657 6657
Branches 696 696
=======================================
Hits 6202 6202
Misses 331 331
Partials 124 124
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 130 130
Lines 6657 6657
Branches 696 696
=======================================
Hits 6202 6202
Misses 331 331
Partials 124 124
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
I have:
Description
Switches the display of token expiry date time in the create token screen from:
to: