Fix versions of python modules not being set in docker images #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versioning permissions issue
greenape
added
bug
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 136 136
Lines 6861 6861
Branches 697 697
=======================================
Hits 6404 6404
+ Misses 333 332 -1
- Partials 124 125 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 92.77% 93.92% +1.15%
==========================================
Files 140 140
Lines 6902 6902
Branches 693 693
==========================================
+ Hits 6403 6483 +80
+ Misses 380 308 -72
+ Partials 119 111 -8
Continue to review full report at Codecov.
|
maxalbert
reviewed
Jul 1, 2019
maxalbert
reviewed
Jul 1, 2019
Co-Authored-By: maxalbert <[email protected]>
maxalbert
reviewed
Jul 1, 2019
| @@ -382,7 +382,7 @@ def render_pep440_post(pieces): | |||
|
|
|||
| The ".dev0" means dirty. Note that .dev0 sorts backwards | |||
| (a dirty tree will appear "older" than the corresponding clean one), | |||
| but you shouldn't be releasing software with -dirty anyway. | |||
| but you shouldn't be releasing software with -dirty anyways. | |||
maxalbert
reviewed
Jul 1, 2019
| RUN python setup.py bdist_wheel && pip install dist/*.whl | ||
| WORKDIR /app | ||
| COPY backend/uwsgi.ini . |
There was a problem hiding this comment.
What exactly is the purpose of this uwsgi.ini file? Should this be included in the distribution instead (e.g. via MANIFEST.in)?
There was a problem hiding this comment.
It configures uwsgi, which is serving the app in combination with nginx. So is deployment-side rather than distribution side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #818
I have:
Description
Uses versioneer's ability to infer a version number from a source tree to set the version numbers for python modules inside docker containers.