Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flowmachine subscriber degree #991

Merged
merged 11 commits into from
Jul 1, 2019
Merged

Flowmachine subscriber degree #991

merged 11 commits into from
Jul 1, 2019

Conversation

BhavinPanch
Copy link
Contributor

@BhavinPanch BhavinPanch commented Jun 27, 2019 •
edited
Loading

Closes #969

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Exposed subscriber degree information via joined spatial aggregate of FlowAPI

@greenape greenape added FlowMachine Issues related to FlowMachine enhancement New feature or request FlowClient Issues related to FlowClient labels Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #991 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #991     +/-   ##
=========================================
+ Coverage   93.18%   93.38%   +0.2%     
=========================================
  Files         131      138      +7     
  Lines        6165     6911    +746     
  Branches      699      699             
=========================================
+ Hits         5745     6454    +709     
- Misses        295      332     +37     
  Partials      125      125
Flag Coverage Δ
#flowapi_unit_tests 77.27% <ø> (ø) ⬆️
#flowauth_unit_tests 94.86% <ø> (?)
#flowclient_unit_tests 81.99% <50%> (-0.31%) ⬇️
#flowetl_unit_tests 100% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 90.98% <73.91%> (-0.08%) ⬇️
#integration_tests 60.62% <100%> (+0.42%) ⬆️
Impacted Files Coverage Δ
...e/server/query_schemas/joined_spatial_aggregate.py 100% <100%> (ø) ⬆️
...ine/core/server/query_schemas/subscriber_degree.py 100% <100%> (ø)
flowclient/flowclient/client.py 93.83% <100%> (+0.05%) ⬆️
flowauth/backend/flowauth/login.py 93.75% <0%> (ø)
flowauth/backend/flowauth/models.py 95.58% <0%> (ø)
flowauth/backend/flowauth/admin.py 97.45% <0%> (ø)
flowauth/backend/flowauth/invalid_usage.py 93.33% <0%> (ø)
flowauth/backend/flowauth/token_management.py 94.25% <0%> (ø)
flowauth/backend/flowauth/spatial_aggregation.py 58.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef872e...b6553c5. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #991 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #991     +/-   ##
=========================================
+ Coverage   93.18%   93.38%   +0.2%     
=========================================
  Files         131      138      +7     
  Lines        6165     6911    +746     
  Branches      699      699             
=========================================
+ Hits         5745     6454    +709     
- Misses        295      332     +37     
  Partials      125      125
Flag Coverage Δ
#flowapi_unit_tests 77.27% <ø> (ø) ⬆️
#flowauth_unit_tests 94.86% <ø> (?)
#flowclient_unit_tests 81.99% <50%> (-0.31%) ⬇️
#flowetl_unit_tests 100% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 90.98% <73.91%> (-0.08%) ⬇️
#integration_tests 60.62% <100%> (+0.42%) ⬆️
Impacted Files Coverage Δ
...e/server/query_schemas/joined_spatial_aggregate.py 100% <100%> (ø) ⬆️
...ine/core/server/query_schemas/subscriber_degree.py 100% <100%> (ø)
flowclient/flowclient/client.py 93.83% <100%> (+0.05%) ⬆️
flowauth/backend/flowauth/login.py 93.75% <0%> (ø)
flowauth/backend/flowauth/models.py 95.58% <0%> (ø)
flowauth/backend/flowauth/admin.py 97.45% <0%> (ø)
flowauth/backend/flowauth/invalid_usage.py 93.33% <0%> (ø)
flowauth/backend/flowauth/token_management.py 94.25% <0%> (ø)
flowauth/backend/flowauth/spatial_aggregation.py 58.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef872e...b6553c5. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #991 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   93.34%   93.38%   +0.03%     
==========================================
  Files         137      138       +1     
  Lines        6886     6911      +25     
  Branches      699      699              
==========================================
+ Hits         6428     6454      +26     
+ Misses        333      332       -1     
  Partials      125      125
Flag Coverage Δ
#flowapi_unit_tests 77.27% <ø> (ø) ⬆️
#flowauth_unit_tests 94.86% <ø> (ø) ⬆️
#flowclient_unit_tests 81.99% <50%> (-0.31%) ⬇️
#flowetl_unit_tests 100% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 90.98% <73.91%> (-0.08%) ⬇️
#integration_tests 60.65% <100%> (+0.5%) ⬆️
Impacted Files Coverage Δ
...e/server/query_schemas/joined_spatial_aggregate.py 100% <100%> (ø) ⬆️
...ine/core/server/query_schemas/subscriber_degree.py 100% <100%> (ø)
flowclient/flowclient/client.py 93.83% <100%> (+0.05%) ⬆️
flowmachine/flowmachine/core/cache.py 95.76% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83df27...42a5536. Read the comment docs.

greenape
greenape requested changes Jul 1, 2019
View reviewed changes
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a misleading docstring.

flowclient/flowclient/client.py
ISO format date of the first day of the count, e.g. "2016-01-01"
stop : str
ISO format date of the day _after_ the final date of the count, e.g. "2016-01-08"
direction : {"in", "out", "both"}, default "both"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a default defined in the function here?

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Jul 1, 2019
@mergify mergify bot merged commit 2c5fda2 into master Jul 1, 2019
@mergify mergify bot deleted the flowmachine-subscriber-degree branch July 1, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxalbert maxalbert maxalbert left review comments

@greenape greenape greenape approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose SubscriberDegree via api
3 participants
@BhavinPanch @greenape @maxalbert