Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [QoL] Toggles (Most) Eating and Drinking sounds #5429

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4904

About The Pull Request

This attacks the 97% of the eating and drinking sounds, it doesnt fixes stuff like xenobio reproductives, unalive verbs and other small variations that use the same sound, is just for when you as a basic mob or human try to eat or drink something, so you dont get the slurp from yourself or others. It's a toggle thats saves per player, as other sound toggles

How This Contributes To The Nova Sector Roleplay Experience

Well, sometimes the over the top sounds of drinking and eating can be completly disruptive to the experience, and sound so bad that they even seem caricaturesque. This allow each individual player to opt in or out of these sounds.

Additionally, it allows people with Misophonia to suffer not the eating of others and to even play things other than robots and podpeople.

Proof of Testing

Screenshots/Videos

image

image

I dont have the video thingie.

Changelog

🆑 OrbisAnima
qol: Made a new config in the Game Preferences Sound Menu to toggle eating and drinking sounds.
/:cl:

OrbisAnima and others added 2 commits February 19, 2025 04:33
* Initial Commit

* Fucking Lint

* Update code/datums/components/food/edible.dm

Co-authored-by: Bloop <[email protected]>

* Update code/datums/elements/basic_eating.dm

Co-authored-by: Bloop <[email protected]>

* Update code/datums/elements/basic_eating.dm

Co-authored-by: Bloop <[email protected]>

* Update code/modules/reagents/reagent_containers/cups/_cup.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
@FeenieRU FeenieRU merged commit dd02e6c into master Feb 20, 2025
33 checks passed
AnywayFarus added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants