Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [Feature] Adds Pet Treats that make them Inmune to Space - Port from ABoxFaux + own twist #5435

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4907

About The Pull Request

Ported from here: Bubberstation/Bubberstation#3089

Credit for sprites and code to @ABoxFaux

So, what this code does is create an item, that spawns for free to the user of the pet owner quirk, and can also be obtained from the donk co import for 100 credits, that makes a basic mob inmune to pressure damage and more resistant to temperatures, enough that they can survive in space.

In the original code they were 250 credits and only obtainaible from cargo, but I felt that ghost roles would suffer from it, and certainly pet owners would always get the item, so, I decided to avoid such tax, while encouraging its visibility due to imports and in case people want to order them for pets they obtain on the way.

How This Contributes To The Nova Sector Roleplay Experience

It simplifies the care of pets that otherwise wouldnt be able to survive space for one reason or another, and often times its quite the sad event to see, which would desentize people from the attachment of their pets. This fix would had been better with a technological twist but I felt the code solution would had been more complex, so while it feels a tad magical, as we do have genetics with the same properties and such is not too far fetched for in setting explanations.

Proof of Testing

Screenshots/Videos

image

image

image

image

image

image

image

image

image

image

Changelog

🆑 OrbisAnima
add: Introducing from Donk Co new line of Genetic Pet Treats the Treat Breather, capable of adapting the DNA of your animal companion to the cold and dangers of the void of space. Now Available in Cargo Imports and to Certified Pet Owners. May contain Space Carp and Soy Traces! (Credits to ABoxFaux for sprites and original code!)
/:cl:

OrbisAnima and others added 2 commits February 19, 2025 17:30
…ABoxFaux + own twist (#4907)

* Initial Commit - Port from Bubber + own adaptions

Credit for sprites and original code to @ABoxFaux

Co-Authored-By: ABoxFaux <[email protected]>

* Renamed to go with suggestion

Co-Authored-By: ABoxFaux <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update pet_items.dm

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Fixes List check to make sure non pets dont get the benefits

with Vinil's help

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_items/code/pet_items.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: ABoxFaux <[email protected]>
Co-authored-by: Bloop <[email protected]>
@FeenieRU FeenieRU merged commit 777b10a into master Feb 20, 2025
33 of 34 checks passed
AnywayFarus added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants