Fix lazy soundfont unloading #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If polyphony is exceeded and FluidSynth has to allocate a voice by calling fluid_synth_free_voice_by_kill_LOCAL(), two problems occur: 1)The value returned by fluid_synth_get_active_voice_count() never returns back to 0. 2)SoundFont samples are not unref'd properly, and therefore if an attempt is made to unload the SoundFont, the deferred unload timer is started, and fluid_synth_sfunload_callback() unsuccessfully tries to unload the SoundFont forever. These 2 issues are fixed by this commit.
derselbst
force-pushed
the
fix-sfunload
branch
from
7f95fe5 to
8f138fd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the lazy soundfont unloading mechanism, i.e. fixes #727.
(Regression tests should be merged first to see that CI passes.)