Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Version 5.1.0+1 is incompatible with flutter_svg ^2.0.0+1 #352

Closed
2 tasks done
jayjah opened this issue Feb 4, 2023 · 5 comments
Closed
2 tasks done

[BUG]: Version 5.1.0+1 is incompatible with flutter_svg ^2.0.0+1 #352

jayjah opened this issue Feb 4, 2023 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@jayjah
Copy link

jayjah commented Feb 4, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Version

5.1.0+1

Command type

build_runner (Default)

What happened?

Current version of flutter_gen_runner is incompatible with the new version of flutter_svg: 2.0.0+1.
See log output for details.

Relevant a pubspec.yaml.

flutter_gen:
  output: lib/src/assets/
  line_length: 80

  integrations:
    flutter_svg: true
  assets:
    enabled: true
  fonts:
    enabled: true

Relevant log output

lib/src/assets/assets.gen.dart:385:14: Error: The argument type 'SvgTheme?' can't be assigned to the parameter type 'SvgTheme' because 'SvgTheme?' is nullable and 'SvgTheme' isn't.
 - 'SvgTheme' is from 'package:vector_graphics_compiler/src/svg/theme.dart' ('../../.pub-cache/hosted/pub.dev/vector_graphics_compiler-1.0.1/lib/src/svg/theme.dart').
      theme: theme,
             ^
Target kernel_snapshot failed: Exception

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jayjah jayjah added the bug Something isn't working label Feb 4, 2023
@jayjah
Copy link
Author

jayjah commented Feb 4, 2023

Following PR-350 is addressing this Issue. So I think it's best to close this issue as soon as the PR lands and get published on pub.dev

@wasabeef
Copy link
Member

wasabeef commented Feb 7, 2023

@jayjah
Thank you for your reporting.
We'll be releasing it in the next few days.

@wasabeef wasabeef added this to the 5.2.0 milestone Feb 7, 2023
@wasabeef
Copy link
Member

wasabeef commented Feb 7, 2023

@jayjah
Thank you for always supporting me. I just released the v5.2.0.

@noinskit
Copy link

noinskit commented Feb 9, 2023

This was a backward incompatible change. Would you be so kind and make similar changes with a major version bump in the future? It's not always easy to upgrade, e.g. I've got a project where I can't trivially upgrade to flutter_svg 2.0.0 due to conflicts caused by its dependencies.

@jayjah
Copy link
Author

jayjah commented Feb 9, 2023

@wasabeef That's great to hear! Thank you! I'll close this issue as it's resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants