Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] [UI] As a user, I can see the Splash screen #40

Merged
merged 7 commits into from
Mar 14, 2023

Conversation

hoangnguyen92dn
Copy link
Owner

@hoangnguyen92dn hoangnguyen92dn commented Mar 9, 2023

Close #3

What happened 👀

Add Splash screen as the default screen will be shown when launch application

Insight 📝

  • Add flutter_svg library to support .svg format and flutter_gen to manage resources
  • Apply SystemOverlayStyle to transparent the status bar
SystemChrome.setSystemUIOverlayStyle(
        const SystemUiOverlayStyle(statusBarColor: Colors.transparent));

Proof Of Work 📹

SVID_20230309_142123_1.mp4

@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 08:54 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 08:54 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn marked this pull request as ready for review March 9, 2023 08:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #40 (24c76ec) into develop (742594a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #40   +/-   ##
========================================
  Coverage    19.23%   19.23%           
========================================
  Files            3        3           
  Lines           52       52           
========================================
  Hits            10       10           
  Misses          42       42           
Flag Coverage Δ
unittests 19.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hoangnguyen92dn hoangnguyen92dn self-assigned this Mar 9, 2023
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 09:53 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 09:53 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 10:24 — with GitHub Actions Inactive
Base automatically changed from chore/2-setup-cicd to develop March 10, 2023 03:11
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 10, 2023 03:11 — with GitHub Actions Inactive
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

lib/ui/splash_screen.dart Outdated Show resolved Hide resolved
lib/ui/splash_screen.dart Outdated Show resolved Hide resolved
lib/ui/splash_screen.dart Outdated Show resolved Hide resolved
lib/main.dart Show resolved Hide resolved
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 14, 2023 02:40 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 14, 2023 02:40 — with GitHub Actions Inactive
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@Wadeewee Wadeewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hoangnguyen92dn hoangnguyen92dn merged commit ccb1332 into develop Mar 14, 2023
@hoangnguyen92dn hoangnguyen92dn deleted the feature/3-implement-splash-screen branch March 14, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] As a user, I can see the Splash screen
4 participants