-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function fleaves
#73
Conversation
return Iterators.flatten(_map(recurse, func, yfuncs...)) | ||
x_children = children(x) | ||
ys_children = map(children, ys) | ||
return Iterators.flatten(_map(recurse, x_children, ys_children...)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no functional changes here, only improved clarity
Implementation looks good and I'm on board with adding something like this. Only thing is that this isn't It'd be nice to have something like a real |
Changed name to |
this is ready to go |
Adds utility function
fflattenfleaves
that flatten the leaves into an array, similarly to jax's tree_leaves.Useful for models' parameters collection: