Widen in _grad!
#66
Merged
Widen in _grad!
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
approved these changes
Apr 20, 2022
|
This supersedes #65 |
|
Can this get a tag? I'd like to see if it fixes the last bits of SciML/DiffEqFlux.jl#699 so we can merge 0.13 support. |
|
Tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered in SciML/DiffEqFlux.jl#699, that the adjoint of
rehas to allow for (some of) the leaves having a wider type than the original vector.This approach costs a copy when this happens, but is much simpler than trying to walk the tree and infer the eltype before starting.