Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add "Preview" mode to Manage Google-Fonts mode #250

Closed
spezialspezial opened this issue Nov 24, 2021 · 3 comments
Closed

Comments

@spezialspezial
Copy link

Not a huge issue but "Preview" mode (editable sample text, all characters, justification) is missing when in Manage -> G mode. Only Waterfall and Lorem Ipsum is availiable. Not sure if this is for technical reasons. Just in case it's easy to add I wanted to mention it's missed as it's my favorite mode.

@JerryCasiano
Copy link
Contributor

It is for technical reasons actually.

We would need to involve actual JavaScript for something like that to work.

At that point, we would probably be better off dumping the pure GTK widget and just using a WebView for previews everywhere in the application.

Which may or may not be a bad idea actually.

I don't know... I considered doing it for consistency but didn't really want to go that far with it at the time.

I think I'll leave this open for now and revisit it later. May be a while though. Possibly something to seriously consider in a GTK 4 or 5 port.

Thanks for your interest.

@spezialspezial
Copy link
Author

No problem, could have been a simple oversight.

@JerryCasiano
Copy link
Contributor

I'm closing this out now as this is already done in the wip branch and will be in the next release.

Thanks for the push.

JerryCasiano added a commit that referenced this issue Jun 16, 2024
- Closes #297
- Closes #316
- Closes #250
- Closes #332
- Closes #330
- Closes #349
- Closes #319
- Closes #286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants