Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone node #89

Merged
merged 11 commits into from
Feb 25, 2019
Merged

Clone node #89

merged 11 commits into from
Feb 25, 2019

Conversation

mehmetscoskun
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 22, 2019

Pull Request Test Coverage Report for Build 905

  • 24 of 26 (92.31%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 94.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nodesFactory/DomBackedNodesFactory.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 883: -0.006%
Covered Lines: 5872
Relevant Lines: 6197

💛 - Coveralls

@@ -29,6 +29,7 @@
"fs.js",
"loader.js"
],
"smartStep": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this comment at the row above:
// smartStep can be enabled again once microsoft/vscode#68616 is fixed. TLDR; smartStep causes parts of code to not be highlighted when debugging unit tests.

@mehmetscoskun mehmetscoskun merged commit fab1d61 into master Feb 25, 2019
@mehmetscoskun mehmetscoskun deleted the clone-node branch February 25, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants