Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

catch pry breakpoints #36

Closed
bryanwb opened this issue May 22, 2012 · 7 comments
Closed

catch pry breakpoints #36

bryanwb opened this issue May 22, 2012 · 7 comments

Comments

@bryanwb
Copy link

bryanwb commented May 22, 2012

pry is an awesome debugging tool but it is too easy to leave breakpoints like the following in your code

... some recipe code
require 'pry'
binding.pry
... more code

@acrmp
Copy link
Member

acrmp commented May 22, 2012

Great idea. We'd want to check for either of these two lines in any *.rb file - libraries, recipes, lwrp's...

Do you use pry from within template code (erubis)?

@bryanwb
Copy link
Author

bryanwb commented May 22, 2012

I have not tried it in an erubis template but I will eventually. No idea whether or not it works in erubis templates

@acrmp
Copy link
Member

acrmp commented May 22, 2012

It should be possible to use pry within code blocks in a template in which case the rule could check for this as well - I don't know if people are actually doing this though in normal usage.

Separately you've made me think that a rule to look for naming inconsistencies between the variables passed into a template versus those used in the template would be a useful addition too.

@acrmp
Copy link
Member

acrmp commented Jun 3, 2012

Hi Bryan,

I've added a new rule FC030 to master for this. Can you give it a try and let me know if it works for you.

Cheers,

Andrew.

@bryanwb
Copy link
Author

bryanwb commented Jun 4, 2012

will try to test it out today, tks

On Sun, Jun 3, 2012 at 11:05 PM, Andrew Crump <
[email protected]

wrote:

Hi Bryan,

I've added a new rule FC030 to master for this. Can you give it a try and
let me know if it works for you.

Cheers,

Andrew.


Reply to this email directly or view it on GitHub:
#36 (comment)

@bryanwb
Copy link
Author

bryanwb commented Jun 4, 2012

works nicely! tks to the Crumpster! Everyone's favorite iguana :)

@bryanwb bryanwb closed this as completed Jun 4, 2012
@acrmp
Copy link
Member

acrmp commented Jun 4, 2012

I don't know what that means. I hereby challenge you to a dance battle:
http://www.youtube.com/watch?v=pr9h_7qZ94M

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants