This repository has been archived by the owner on Sep 19, 2020. It is now read-only.
Add self-dependency warning #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@lamont-granquist We should add this for the 5.1 release. Update the rule number and lets get this merged. |
lamont-granquist
force-pushed
the
lcg/055-add-self-dependency-warning
branch
from
aa200a5 to
6d85edf
Compare
|
@lamont-granquist Travis is failing |
Chef does not require cookbooks to depend on themselves in order to depsolve. In addition to this line being useless, it actually creates problems with depsolving. The self-dependency can create a circular dependency where every version of a cookbook will satisfy the circular dependency on itself which can create a huge mess. Ideally we need to fix this elsewhere in the ecosystem as well, but for now this will at least surface the issue to cookbook authors who use foodcritic.
lamont-granquist
force-pushed
the
lcg/055-add-self-dependency-warning
branch
from
6d85edf to
994e900
Compare
|
@tas50 still had a couple of references to "055" that needed to be "063" instead. fixed. squashed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chef does not require cookbooks to depend on themselves in order to
depsolve. In addition to this line being useless, it actually creates
problems with depsolving. The self-dependency can create a circular
dependency where every version of a cookbook will satisfy the circular
dependency on itself which can create a huge mess.
Ideally we need to fix this elsewhere in the ecosystem as well, but
for now this will at least surface the issue to cookbook authors who
use foodcritic.