add checks for correct use of use_inline_resources

[lamont-granquist]

• recommend use_inline_resource in all 'LWRPBase' providers
• catch the use of use_inline_resources when users are also declaring
  def action_whatever instead of action :whatever which defeats
  use_inline_resources

[coderanger]

👍 as it is restricted to LWRPBase-based things.

[lamont-granquist]

Yeah, I'm certainly intending to only target the bodies of classes that inherit from Providers::LWRPBase, we'll have to see how buggy my Ruby AST XPath parsing foo is -- but it does have a test that it avoids the simple case of a library file with only a resource in it, which does not declare use_inline_resources and ignores that. I'm not sure I could actually do any 'better' than that, since we're doing static analysis.

There might be edge cases where an abstract base class inherits from LWRPBase but doesn't declare use_inline_resources, even though all the subclasses do, but I think the solution there is to either move use_inline_resources up to the baseclass or else just comment out the FC rule.

[lamont-granquist]

@jaymzh @tas50 etc got any thoughts to add about this one?

[tas50]

Looks like this description didn't get filled out

[philoserf]

I approve AND I prefer on rule per Pull Request.

👍

[lamont-granquist]

rebased, squashed, fixed the merge conflicts over the numbering...