This repository has been archived by the owner on Sep 19, 2020. It is now read-only.
Fix FC033 false positives #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
To be honest I'm not entirely sure what was going on here before, but it certainly seemed complex for what we're trying to do. All we need to do is see if anything in the templates match the sources defined template file. We have a method for grabbing all the templates and it does the right thing out of the box returning templates that are in the root of the templates dir (vs. in default or what not). I tested this against the working cookbook and then put in a bogus template source and it triggered there as expected.
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
|
Do you want any help on this PR? |
|
@docwhat This just needs proper tests written and it can be merged. |
|
Going with #485 instead since it has the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest I'm not entirely sure what was going on here before, but it
certainly seemed complex for what we're trying to do. All we need to do
is see if anything in the templates match the sources defined template
file. We have a method for grabbing all the templates and it does the
right thing out of the box returning templates that are in the root of
the templates dir (vs. in default or what not). I tested this against
the working cookbook and then put in a bogus template source and it
triggered there as expected.