This repository has been archived by the owner on Sep 19, 2020. It is now read-only.
Remove FC003 from Foodcritic #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer makes sense now that solo uses local mode and search works with that. Update the test helper to no longer use FC003 since we tested with that in several places Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
iennae
reviewed
Mar 3, 2017
| @@ -16,7 +16,7 @@ def assertions | |||
| WARNINGS = { | |||
| "FC001" => "Use strings in preference to symbols to access node attributes", | |||
| "FC002" => "Avoid string interpolation where not required", | |||
| "FC003" => "Check whether you are running with chef server before using server-specific features", | |||
| # FC003 was yanked and is considered reserved, do not reuse it | |||
There was a problem hiding this comment.
yanked might not make sense to international audience. maybe "FC003 has been deprecated and is considered reserved.."
There was a problem hiding this comment.
This is just copy pasta from the last FC rule we deprecated. The actual docs for FC word is differently. This is just a code comment to prevent devs from reusing the number
iennae
reviewed
Mar 3, 2017
| end | ||
| end | ||
| end | ||
| # FC003 was yanked and the number should not be reused |
There was a problem hiding this comment.
FC003 was a check for Chef server specific features that
did not interoperate with the implementation of chef-solo.
It has been deprecated, and should not be reused.
There was a problem hiding this comment.
Making it a comment makes it think I meant this as a giant header. doh.
There was a problem hiding this comment.
Same as above these aren't actually seen by end users so the wording isn't the important part. That's for the PR against foodcritic-site
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It no longer makes sense now that solo uses local mode and search works with that.
Signed-off-by: Tim Smith [email protected]