Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Remove FC023 which is no longer considered best practice #523

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Remove FC023 which is no longer considered best practice #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions features/023_check_for_condition_around_resource.feature
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion features/support/command_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def assertions
"FC019" => "Access node attributes in a consistent manner",
"FC021" => "Resource condition in provider may not behave as expected",
"FC022" => "Resource condition within loop may not behave as expected",
"FC023" => "Prefer conditional attributes",
# FC023 was yanked and is considered reserved, do not reuse it
"FC024" => "Consider adding platform equivalents",
"FC025" => "Prefer chef_gem to compile-time gem install",
"FC026" => "Conditional execution block attribute contains only string",
Expand Down
11 changes: 0 additions & 11 deletions lib/foodcritic/rules/fc023.rb
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions spec/regression/expected-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,18 +292,6 @@ FC019: Access node attributes in a consistent manner: perl/recipes/default.rb:26
FC019: Access node attributes in a consistent manner: powershell/recipes/default.rb:69
FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:1
FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:2
FC023: Prefer conditional attributes: ./apt/providers/repository.rb:26
FC023: Prefer conditional attributes: ./apt/providers/repository.rb:68
FC023: Prefer conditional attributes: ./chef-client/recipes/config.rb:62
FC023: Prefer conditional attributes: ./database/recipes/ebs_backup.rb:81
FC023: Prefer conditional attributes: ./gecode/recipes/package.rb:29
FC023: Prefer conditional attributes: ./homebrew/providers/tap.rb:14
FC023: Prefer conditional attributes: ./homebrew/providers/tap.rb:22
FC023: Prefer conditional attributes: ./lvm/providers/volume_group.rb:12
FC023: Prefer conditional attributes: ./passenger_apache2/recipes/mod_rails.rb:27
FC023: Prefer conditional attributes: ./users/providers/manage.rb:70
FC023: Prefer conditional attributes: ./users/providers/manage.rb:101
FC023: Prefer conditional attributes: ./yum/providers/key.rb:59
FC024: Consider adding platform equivalents: ./mysql/recipes/server.rb:130
FC024: Consider adding platform equivalents: ./mysql/recipes/server.rb:132
FC024: Consider adding platform equivalents: ./transmission/recipes/default.rb:42
Expand Down