Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for floating constant #187

Closed
kant2002 opened this issue Aug 9, 2022 · 0 comments · Fixed by #189
Closed

Add support for floating constant #187

kant2002 opened this issue Aug 9, 2022 · 0 comments · Fixed by #189
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors

Comments

@kant2002
Copy link
Collaborator

kant2002 commented Aug 9, 2022

Cesium has floating data types, but not floating point constants.
Would be nice to add support for it.

Basically if start from

Cesium/Cesium.CodeGen/Ir/Expressions/ConstantExpression.cs

Line 34 in ad0a6b3

CTokenType.IntLiteral => new IntegerConstant(constant.Text),

and create FloatConstant in similar wat to IntegerConstant we have it.
@Fantoom Fantoom mentioned this issue Aug 12, 2022
Merged
1 task
@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors labels Aug 13, 2022
ForNeVeR added a commit to Fantoom/Cesium that referenced this issue Aug 17, 2022
@ForNeVeR
(ForNeVeR#187) Constants: fix grammar and use the right exception types
24a492c
ForNeVeR added a commit to Fantoom/Cesium that referenced this issue Aug 17, 2022
@ForNeVeR
(ForNeVeR#187) FloatingPointConstant: a new type, more architecturall…
8f22da7 
…y correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Floating point constant expression Fantoom/Cesium
2 participants
@ForNeVeR @kant2002