(#74) Basic switch-case support
#139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Merged
kant2002
reviewed
Aug 27, 2022
| private static Statement MakeLabelStatement(IToken identifier, IToken _, Statement block) => | ||
| new LabelStatement(identifier.Text, block); | ||
|
|
||
| // TODO: constant or constant-expression? What's difference? gsomix. |
There was a problem hiding this comment.
@gsomix constant is just 5 , constant-expression can be 4+5
|
After #302 lands we can model |
kant2002
added a commit
to kant2002/Cesium
that referenced
this pull request
Oct 13, 2022
A lot of noise comes from fact that I distiguish between constant literals and constant expressions. We incorrectly name ConstantExpresion the expression which works with constants, but that's more broad concept. In the spec names are `constant` and `constant-expression` and because we have suffix Expression to all expression we have a clash. Closes ForNeVeR#74 and superseeds ForNeVeR#139
Merged
|
Superseded by #316. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74