Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow typdefs on partial declarations for struct/enum #501

Merged
merged 6 commits into from
Dec 23, 2023
Merged

Allow typdefs on partial declarations for struct/enum #501

merged 6 commits into from
Dec 23, 2023

Conversation

kant2002
Copy link
Collaborator

@kant2002 kant2002 commented Dec 9, 2023

disallow enum and struct to share name

@ForNeVeR ForNeVeR self-assigned this Dec 9, 2023
@ForNeVeR ForNeVeR self-requested a review December 9, 2023 19:03
ForNeVeR
ForNeVeR requested changes Dec 11, 2023
View reviewed changes
Cesium.CodeGen/Contexts/TranslationUnitContext.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Contexts/TranslationUnitContext.cs Show resolved Hide resolved
Cesium.CodeGen/Ir/Types/PointerType.cs Outdated Show resolved Hide resolved
@ForNeVeR ForNeVeR assigned kant2002 and ForNeVeR and unassigned ForNeVeR Dec 11, 2023
@ForNeVeR ForNeVeR self-requested a review December 19, 2023 20:54
ForNeVeR
ForNeVeR requested changes Dec 19, 2023
View reviewed changes
Cesium.CodeGen/Ir/Types/PointerType.cs Outdated Show resolved Hide resolved
Cesium.Compiler/Properties/launchSettings.json Outdated Show resolved Hide resolved
@ForNeVeR ForNeVeR assigned kant2002 and unassigned ForNeVeR Dec 19, 2023
ForNeVeR
ForNeVeR approved these changes Dec 23, 2023
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 532fbec into ForNeVeR:main Dec 23, 2023
3 checks passed
@kant2002 kant2002 deleted the kant/partial-typedefs branch December 24, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@kant2002 kant2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kant2002 @ForNeVeR