Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the grid by removing intersection artifacts #72

Conversation

SarthakSingh31
Copy link
Contributor

Improved the grid that is rendered by removing artifacts that are generated when lines with different colors intersect.
Switched to using alpha blending in a hierarchical order to achieve perfect looking intersections.

Before (render time: 0.26ms):
Screenshot From 2024-12-20 23-14-01

After (render time: 0.33ms):
Screenshot From 2024-12-20 23-13-00

Sorry about the random rustfmt changes.

Copy link

fslabs-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fslabs-bot bot commented Dec 20, 2024

Welcome @SarthakSingh31! It looks like this is your first PR to ForesightMiningSoftwareCorporation/bevy_infinite_grid 🎉

@fslabs-bot fslabs-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@IceSentry
Copy link
Collaborator

IceSentry commented Jan 7, 2025

Hey, thank you for the PR, could you remove all the files that are unrelated to the PR? I think only the shader needs to change. All the other rust files seem unrelated.

I never noticed those artifacts before, but now I can't unsee them so I do want to merge this.

@fslabs-bot fslabs-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@SarthakSingh31
Copy link
Contributor Author

@IceSentry remove the other changes. It only has the shader changes now.

@IceSentry
Copy link
Collaborator

Thank you!

@IceSentry IceSentry merged commit d12d11e into ForesightMiningSoftwareCorporation:main Jan 9, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants