Sdks 3608 add missing docs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahancouver
requested review from
spetrov,
jeyanthanperiyasamy,
witrisna,
rodrigoareis and
george-bafaloukas-forgerock
spetrov
requested changes
Dec 9, 2024
Oidc/Oidc/OpenIdConfiguration.swift
Outdated
| @@ -11,12 +11,17 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| /// Struct epresenting the OpenID Connect configuration. | |||
| @@ -19,7 +19,7 @@ public protocol Encryptor { | |||
| /// - Throws: An error if encryption fails. | |||
| func encrypt(data: Data) async throws -> Data | |||
|
|
|||
| // Decrypts the given data. | |||
| /// Decrypts the given data. | |||
There was a problem hiding this comment.
Should the decrypt function be defined as public?
There was a problem hiding this comment.
@spetrov in protocol definitions we cannot specify access modifiers
(XCODE: Protocol requirements implicitly have the same access as the protocol itself)
| @@ -19,7 +19,7 @@ public protocol Encryptor { | |||
| /// - Throws: An error if encryption fails. | |||
| func encrypt(data: Data) async throws -> Data | |||
There was a problem hiding this comment.
Should the encrypt function be defined as public here?
spetrov
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDKS-3608 [iOS][Ping SDK] Missing docs for public interfaces
Also updated the podspecs and file copyrights