Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdks 3728 swift 6 support #31

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Sdks 3728 swift 6 support #31

merged 6 commits into from
Mar 6, 2025

Conversation

vahancouver
Copy link
Contributor

SDKS-3728 [iOS] Revisit Swift 6 support (part 1/2)

Update the following modules to support Swift 6 and complete strict concurrency mode

  • Logger
  • Storage
  • Orchestrate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. We need to figure out the tests on the CI to make sure nothing else is broken though. Few questions/comment left for discussion

@vahancouver
Copy link
Contributor Author

Changes look good to me. We need to figure out the tests on the CI to make sure nothing else is broken though. Few questions/comment left for discussion

@george-bafaloukas-forgerock Addressed the comments and updated the github workflow to use newer xcode and simulator that supports Swift 6. All tests are passing both locally and on github

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@spetrov spetrov merged commit 333dbd6 into develop Mar 6, 2025
9 checks passed
@spetrov spetrov deleted the SDKS-3728-Swift-6-support branch March 6, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants