-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdks 3728 swift 6 support #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. We need to figure out the tests on the CI to make sure nothing else is broken though. Few questions/comment left for discussion
@george-bafaloukas-forgerock Addressed the comments and updated the github workflow to use newer xcode and simulator that supports Swift 6. All tests are passing both locally and on github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me
SDKS-3728 [iOS] Revisit Swift 6 support (part 1/2)
Update the following modules to support Swift 6 and complete strict concurrency mode