-
Notifications
You must be signed in to change notification settings - Fork 7
BUG: .babelrc is not explicitly pointed to everywhere, sometimes doesn't get used #4
BUG: .babelrc is not explicitly pointed to everywhere, sometimes doesn't get used #4
Comments
Yep. Makes sense. I'm looking into this. |
There's this outstanding pull request: babel/babel-loader#121 Note that I tried putting |
Unless we get some pull requests on some third-party projects merged, or do some kind of path trickery, it's looking to me like custom Note that Babel has a |
@ryan-roemer 👍 Can do. I think we should remove |
@exogen -- Agreed. Thanks! |
This removes `--babelrc` and will require boilerplates and other projects using this archetype to add their own `.babelrc` if they want non-default settings. This PR does not remove the actual `.babelrc` file in this repo – it's not hurting anything, can be used as a reference, and will most likely be used again later when custom babelrc is more widely supported. Reference: #4 (not yet fixed) /cc @boygirl @ryan-roemer
This adds a .babelrc until we can resolve FormidableLabs/builder-react-component#4. Since stage 0 is now being used as intended, bring back `@Radium`. /cc @ryan-roemer @boygirl
...until FormidableLabs/builder-react-component#4 is resolved. /cc @boygirl @ryan-roemer
As @boygirl found in FormidableLabs/victory-component-boilerplate#11, using the
@Radium
syntax in the new Builder-based victory-component-boilerplate doesn't work, because Babel isn't always getting its config from our.babelrc
and thus uses the default settings.With decorator syntax, this uses the correct
.babelrc
and works:builder run build-lib
These do NOT work:
builder run build-dist
andbuilder run test-frontend
Addng
.babelrc
toROOT
makes it work, but we don't want to have to do that.We need a way to pass along our
.babelrc
path to Webpack (for buildingdist
and testing) andisparta
(for coverage) – the latter probably being the most difficult as I don't think an option is exposed./cc @ryan-roemer @boygirl
The text was updated successfully, but these errors were encountered: