Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Eslint 9 crash in has-valid-accessibility-ignores-invert-colors #162

Conversation

stephen-pearce
Copy link
Contributor

@stephen-pearce stephen-pearce commented Oct 2, 2024

Use sourceCode by default instead of deprecated getSourceCode to resolve a crash with eslint 9

Description

Fixes #161

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@zibs zibs self-requested a review October 15, 2024 15:31
Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I think we need a changeset too though!

@stephen-pearce stephen-pearce force-pushed the eslint9-ignores-invert-color-crash branch from 31db9c3 to 6d293b6 Compare October 15, 2024 16:08
@stephen-pearce stephen-pearce merged commit b945d94 into FormidableLabs:master Oct 15, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last release crash with Eslint v9
2 participants