This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
PERF: Only transform functional styles #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing victory#141, I did some profiling and found that `evaluateStyles` was the most time-consuming function. It's currently transforming styles even if it would be a no-op. This only transforms style objects that contain functional styles. This increased FPS by ~30% for me. The most time consuming functions are now all from Radium, as I expected. We'll need to focus our efforts optimizing Radium (or avoiding it) if we'd like to make Victory much faster. /cc @boygirl @bclinkinbeard
|
CI failure appears unrelated, anyone know what's up? |
That's a new one... |
|
Waiting for an upstream bug to be fixed: karma-runner/karma#1768 We could downgrade Karma, but if we sit on this for a short while it'll most likely get fixed. Thanks to @coopy for pointing out. |
|
Spurious Karma bug resolved! Approved! |
exogen
added a commit
that referenced
this pull request
Jan 4, 2016
PERF: Only transform functional styles
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating FormidableLabs/victory#141, I did some profiling and found that
evaluateStyleswas the most time-consuming function in the provided demo. It's currently transforming styles even if it would be a no-op.This change only transforms style objects that contain functional styles. This increased FPS by ~30% for me. The most time consuming functions are now all in Radium, as I expected from previous tests. We'll need to focus our efforts optimizing Radium (or using it more cautiously) if we'd like to make Victory much faster.
/cc @boygirl @bclinkinbeard