This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Perf optimizations #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divmain
force-pushed
the
perf-optimizations
branch
from
d0d0f5c to
6ba3388
Compare
| return function () { | ||
| const args = Array.prototype.slice.call(arguments); | ||
| const hash = args.map((arg) => { | ||
| return (typeof arg === "string" || typeof arg === "number") ? arg : JSON.stringify(arg); |
There was a problem hiding this comment.
This won't work for function args; it might be worth noting in a comment.
|
I'm moving this PR over to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in support of FormidableLabs/victory-chart#93. It include one hot-path performance improvement, as well as a multi-arg memoization function that is consumed by
victory-chart.It looks like I have to update a couple of tests for
getStyles. Also, this PR will probably have to wait until after thevictory-coremerge./cc @boygirl @coopy