Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated babel-plugin-lodash #2965

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 13, 2024

The babel-plugin-lodash has been deprecated for over a year. This plugin automatically replaced lodash imports with their single import equivalents. This also fixes a build warning in Babel about using outdated transformations.

This change removes the plugin, converts all imports to the single import format, and adds an ESLint rule to prevent anyone from incorrectly using the full lodash import in the future.

Notes

  • The import order of some of these files is a bit messy, we should consider an eslint rule for import order
  • This new rule is disabled in the /demos since that folder is deprecated and will eventually be removed

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: b475b71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi Patch
victory-voronoi-container Patch
victory-zoom-container Patch
victory Patch
victory-canvas Patch
victory-histogram Patch
victory-scatter Patch
victory-vendor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 13, 2024 7:00pm

@carbonrobot carbonrobot merged commit e4514a6 into main Nov 13, 2024
7 checks passed
@carbonrobot carbonrobot deleted the build/lodash-babel-plugin branch November 13, 2024 19:09
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants