Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy tidal heating #275

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Dummy tidal heating #275

merged 15 commits into from
Nov 20, 2024

Conversation

nichollsh
Copy link
Contributor

@nichollsh nichollsh commented Nov 19, 2024

Adds a module for dummy tidal heating. This is implemented by simply allowing the user to set the tidal power density H_tide in the configuration file. Closes #190.

This required the following changes:

  • Update radiative equilibrium criterion to account for the interior heat flux F_tide and F_radio. This is because global energy balance is now achieved when $F_{\text{atm}}=F_{\text{tide}}+F_{\text{radio}}$ not when $F_{\text{atm}}=0$, since $F_{\text{tide}}+F_{\text{radio}}$ effectively acts like an $F_{\text{eff}}$ (cf. hot jupiter atmosphere models).
  • Add relative tolerance parameter to radeqm stop condition, rather than just an absolute tolerance (which was called F_crit). See https://web.mit.edu/10.001/Web/Tips/Converge.htm
  • Update plots to include tidal and radiogenic heat fluxes. The radiogenic heating isn't new physics - PROTEUS is just now storing what SPIDER was already calculating.
  • Update configuration files with new parameters.

This also lays the groundwork for implementing a new comprehensive tidal heating and orbital evolution calculation. It's not clear how these other models would operate, but they would at least have to communicate some information relating to tidal heating to the interior models.

Minor things:

@nichollsh
Copy link
Contributor Author

nichollsh commented Nov 19, 2024

You can see the impact of the tidal heating here. The case with 10x stronger heating reaches energy balance with a surface temperature ~300 K hotter. For TRAPPIST-1b, this paper predicts Htidal in excess of 16 nW/kg.

Untitled

@nichollsh nichollsh marked this pull request as ready for review November 19, 2024 17:10
…ontributes to global energy balance calculation, and the corresponding convergence check. Update plots and plotting colours for F_tidal and F_radio
@timlichtenberg
Copy link
Member

Do you want me or someone else to review this already?

@nichollsh
Copy link
Contributor Author

nichollsh commented Nov 20, 2024

@timlichtenberg yes I think this is ready for review now that the tests are passing. If could please have a look at it, then that would be great.


# steady state
[params.stop.steady]
enabled = true
enabled = false
F_crit = 0.8 # Maximum absolute value of F_atm allowed for convergence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in W m-2 as well,right?

Copy link
Member

@timlichtenberg timlichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only question is whether to include actual values also for radiogenic heating in the cfg files now or in a follow-up PR.

@nichollsh nichollsh merged commit e2375fa into main Nov 20, 2024
5 checks passed
@nichollsh nichollsh deleted the hn/tide branch November 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dummy tidal heating calculation
2 participants