-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy tidal heating #275
Dummy tidal heating #275
Conversation
…dated configs. Add rtol to radeqm convergence criterion. Add H_tide to helpfile. Printing
You can see the impact of the tidal heating here. The case with 10x stronger heating reaches energy balance with a surface temperature ~300 K hotter. For TRAPPIST-1b, this paper predicts Htidal in excess of 16 nW/kg. |
…ontributes to global energy balance calculation, and the corresponding convergence check. Update plots and plotting colours for F_tidal and F_radio
Do you want me or someone else to review this already? |
@timlichtenberg yes I think this is ready for review now that the tests are passing. If could please have a look at it, then that would be great. |
|
||
# steady state | ||
[params.stop.steady] | ||
enabled = true | ||
enabled = false | ||
F_crit = 0.8 # Maximum absolute value of F_atm allowed for convergence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in W m-2 as well,right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my only question is whether to include actual values also for radiogenic heating in the cfg files now or in a follow-up PR.
… than starting with M_int=0
Adds a module for dummy tidal heating. This is implemented by simply allowing the user to set the tidal power density
H_tide
in the configuration file. Closes #190.This required the following changes:
F_tide
andF_radio
. This is because global energy balance is now achieved whenF_crit
). See https://web.mit.edu/10.001/Web/Tips/Converge.htmThis also lays the groundwork for implementing a new comprehensive tidal heating and orbital evolution calculation. It's not clear how these other models would operate, but they would at least have to communicate some information relating to tidal heating to the interior models.
Minor things:
apt-get update
to Ubuntu workflow, following this issue: Installing libcurl4-openssl-dev fails actions/runner-images#5470 (comment).