Diagnostic parameters and minor changes #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… orbital period. Remove unused imports and constants
timlichtenberg
approved these changes
Mar 9, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that -- for inflated atmospheres -- the radius of the escaping level can become a large fraction of the Hill radius. This indicates that these atmospheres are close to becoming unbound. It is worth tracking the Hill and Roche radii as diagnostic variables. Similarly, it would be useful to know the WTG parameter in order to estimate the potential for day-night heat redistribution. This PR implements these and closes #261.
The planet's axial period (day length) is now stored as a separate variable to the orbital period. At the moment we set them to be equal, but in the future this might not necessarily be the case. This change comes about because the WTG parameter depends on the axial period of the planet.
This PR also includes a few minor fixes to the plotting functions. In particular, it turns out that some of them were previously failing when executed via the CLI. I have also improved the readability of some of the plots.