Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diefi inheritance keys updates #37

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Diefi inheritance keys updates #37

merged 6 commits into from
Jun 17, 2022

Conversation

mickeyjoes
Copy link
Member

No description provided.

@mickeyjoes mickeyjoes requested a review from zwergius June 17, 2022 12:50
Copy link
Member

@zwergius zwergius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ok usa

const algorithm = { name: key.algorithm.name, iv }
if (algorithm.name === AES_GCM.name) {
algorithm.tagLength = LENGTH_128
if (additionalData) algorithm.additionalData = additionalData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very confusing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will consider writing a new function when implementing this.

@mickeyjoes mickeyjoes merged commit 7becbc7 into master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants