Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing the 2nd, 3rd, 4th [...] occurence of a repeating task via notification doesn't set the task status to completed #156

Closed
7 tasks done
hundertprobert opened this issue Feb 19, 2024 · 11 comments · Fixed by #443
Assignees
Labels
bug Something is not working

Comments

@hundertprobert
Copy link

hundertprobert commented Feb 19, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.2

Affected Android/Custom ROM version

Android 10 / MIUI Global 12.0.10

Affected device model

Xiaomi Mi 9 Lite

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Create a daily repeating task with notification at the starting time
  2. Set it as completed on its first occurence
  3. Receive notification for the following occurence (= on the next day)
  4. within the notification, click on "mark as completed"

Expected behavior

The task should be marked as completed for this day when opening the calendar app and in the widget view.

Actual behavior

The task remains as uncompleted in the calendar view as well as the widget view, despite being marked as completed via notification.

Screenshots/Screen recordings

No response

Additional information

This bug was also reported by users in a discussion of a separate bug, see here: #26 (comment) and here: #26 (comment)

@hundertprobert hundertprobert added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 19, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 19, 2024

Can you reproduce it every time with steps you've written? Because I've tested it on three phones, and every time it works. However, it was always the first occurrence, when in one of the comments you've linked, the problem was for third and further.

Also, is the problem only visual on a widget and calendar view, or is it also incomplete when you go to the task editing view?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Feb 19, 2024
@hundertprobert hundertprobert changed the title Completing a repeating task via notification doesn't set the task status to completed Completing the 2nd, 3rd, 4th [...] occurence of a repeating task via notification doesn't set the task status to completed Feb 21, 2024
@hundertprobert
Copy link
Author

You're right, I just tested it as well with a new task and changed the description above. The first occurence works just fine, the following does not. I've had this happen with a long-running task (a daily reminder) where I then discovered there were 4 or 5 uncompleted occurences in the calendar view that I definitely marked as completed.

Also, is the problem only visual on a widget and calendar view, or is it also incomplete when you go to the task editing view?

The task is also incomplete in the task editing view.

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 21, 2024
@Aga-C Aga-C removed question Further information is requested needs triage Issue is not yet ready for PR authors to take up labels Feb 21, 2024
@MrChocolatine
Copy link

MrChocolatine commented Feb 27, 2024

I also experience this problem, even when I was using the SimpleMobileTools version. (so for a very long time)

  • Google Pixel 4 5G / CalyxOS
  • Google Pixel 6a / GrapheneOS

@popogomo
Copy link

popogomo commented Mar 6, 2024

I can also confirm this issue on Pixel 8 Pro with GrapheneOS

@eggsnpie
Copy link

I've also had this issue even with the first occurrence of an event/task. When I click to mark them completed in the notification, it doesn't. It just acts as if I dismissed them.

Android 14
Pixel 8

@QuestioningEspecialy
Copy link

QuestioningEspecialy commented Jan 7, 2025

noticed this bug a month or so ago and assumed it was just user error until i scrolled my tasks and realized it's been consistent 😐
are y'all just gonna temporarily remove the button from notifications until it gets fixed or what? i thought i didn't take supplements that i already took because of this, so~ it's a deadly serious bug for some users

GrapheneOS
Google Pixel 6a

edit: scrolled my tasks the day of this comment, btw

@eggsnpie
Copy link

eggsnpie commented Jan 7, 2025

This still does happen in the newest versions as well.

@QuestioningEspecialy
Copy link

@naveensingh
gonna add that i find it concerning this hasn't been resolved or atleast well addressed
the least todo for the sake of users is put a clear warning on the Readme and in the latest 3 versions' download page

to be blatant: someone's gonna OD on their meds because of this, so it's quite dangerous and irresponsible to keep things as they are 😐

@naveensingh
Copy link
Member

naveensingh commented Jan 9, 2025

Thanks for the ping.

I'm well aware of the issue and the stakes involved. I do read all the messages here and this issue is on my TODO list.

As for notifying users, there are many open issues that may potentially cause harm to someone somewhere so we cannot add all of them to the README and it probably won't help much anyway since there are many users who don't know what GitHub is. I have started adding an "About => Known issues" option in every app for the same reason.

In the meantime, please avoid using Fossify Calendar for things like medications.

@MrChocolatine
Copy link

MrChocolatine commented Jan 10, 2025

to be blatant: someone's gonna OD on their meds because of this, so it's quite dangerous and irresponsible to keep things as they are

Are you for real? Instead of blaming the app and the author, just take your own responsibility and use another app if this one does not fit your needs ffs.

@QuestioningEspecialy
Copy link

please avoid using Fossify Calendar for things like medications.

you should make that a disclaimer where every user will see it, especially since most users aren't gonna sift through the issues list just in case there's a really important one they should be aware of

@naveensingh naveensingh self-assigned this Jan 21, 2025
fossifybot pushed a commit that referenced this issue Jan 24, 2025
Without this, the intent service will always mark the first occurrence as completed.

See #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants