-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix google pixel month view #154
Conversation
Hey, thanks for the bug fix. I'll check it soon. |
Perfect and thanks a lot that a fix is available since this problem bothered me already in SMT and forced me to switch to Etar. When are you going to check the commit? |
Any update on this by a chance? Thanks. |
Not enough fuel and too much spacetime. I'm looking at it now... |
The logic sounds solid and works fine on the devices I tested. @jonas-w Good work and thanks! This probably also happened on rare devices with non-standard display widths like 1050, 1176, 1260, etc. but those are more common in iPhones. Google is copying everything now. |
@naveensingh no worries, thanks for merging! |
@naveensingh any ETA for a new release of Calendar, so the Google Pixel 8 users can continue using the Fossify Calendar? |
@jonas-w today is the day. |
@naveensingh Thanks a million for this! I know its not easy to maintain so many apps and resolve the issues, so appreciate your efforts greatly! |
@jonas-w @naveensingh Just updated and its working as expected. Thanks a million guys! |
What is it?
Description of the changes in your PR
<
instead of<=
) it instead wrapped the last element always to the next line.Calendar/app/src/main/kotlin/org/fossify/calendar/views/MonthViewWrapper.kt
Line 77 in abd573c
Before/After Screenshots/Screen Record
Before:
As you can see the dates on the right don't have this bounding box which is clickable, and the boxes also went out of the visible area at the bottom.
After:
Now every date has a bounding box that is clickable and no boxes are below the visible area.
Fixes the following issue(s)
Acknowledgement