Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use compressed file without extracting it #100

Closed
wants to merge 1 commit into from

Conversation

BastosLaG
Copy link

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Add option to use compressed file inside the zip file without extracting it eg, If I compressed a video then I view video without extracting like in zarchiver

Fixes the following issue(s)

Acknowledgement

@BastosLaG
Copy link
Author

Thanks to my colleague @PAxitoo for the participation.

@Aga-C
Copy link
Member

Aga-C commented May 16, 2024

The main feature seems to work fine, but I see few issues around it:

  • Every text displayed to user should be in strings.xml, so it can be translated to other languages. Never hardcode them.
  • When I enter a zip file, it's not shown on the breadcrumbs.
  • When I want to go out from the zip, when I press the device's back button, it doesn't return to the previous folder but level above.
  • After entering the zip, in three dots menu there should be an option to unpack the file.
  • Adding to favorites and setting as parent directory should be hidden inside the zip.
  • Changing view type, sorting and showing hidden files shouldn't close the zip file.
  • When you select a file, none of the actions are working. They either throw exceptions or do nothing. IMHO, to make your lives easier, you can just hide these actions, since making them work would be another large feature.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 2, 2024
@fossifybot
Copy link

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

@fossifybot fossifybot closed this Dec 17, 2024
@naveensingh naveensingh removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants