the question of Foundatio.Lock.ILockProvider

[xulei-Itachi]

code:
class Program
{

    private static readonly ILockProvider _lockProvider =
        new CacheLockProvider(new InMemoryCacheClient(), new InMemoryMessageBus());

    static async Task Main(string[] args)
    {
        var @lock = await _lockProvider.AcquireAsync("TestLock", TimeSpan.FromSeconds(5));

        _ = Task.Run(async () =>
          {
              while (true)
              {
                  await Task.Delay(TimeSpan.FromSeconds(3));
                  await @lock.RenewAsync(TimeSpan.FromSeconds(5));
              }
          });

        _ = Task.Run(async () =>
        {
            while (true)
            {
                await Task.Delay(TimeSpan.FromSeconds(3));
                Console.WriteLine($"state: {await _lockProvider.IsLockedAsync("TestLock")}");
            }
        });

        await Task.Delay(-1);
    }

}

the result I Expected is :
state: True
state: True
state: True
state: True
........

but actually, the result is ：
state: True
state: False
state: False
state: False
......

what's the problem?

[xulei-Itachi]

I Found a bug in Foundatio.Caching.InMemoryCacheClient --> ReplaceIfEqualAsync
you didn't update the expire time when update the cache value.

[niemyjski]

Awesome find, any chance you could add this as a test case and submit a pr!

[niemyjski]

@xulei-Itachi could you please submit a pr for this.