-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer processes in coordinator selection for multi-region clusters #2045
Merged
johscheuer
merged 4 commits into
FoundationDB:main
from
johscheuer:prefer-primary-coordinator-selection-multi-region
Jun 4, 2024
Merged
Prefer processes in coordinator selection for multi-region clusters #2045
johscheuer
merged 4 commits into
FoundationDB:main
from
johscheuer:prefer-primary-coordinator-selection-multi-region
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Jun 4, 2024
johscheuer
commented
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new benchmark will present a result like this:
------------------------------
• [0.035 seconds]
Localities chooseDistributedProcesses when a multi-region cluster is used with 4 dcs when measuring the performance for choose distributed processes [measurement]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/internal/locality/locality_test.go:630
Report Entries >>
Choose Distributed Processes - /Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/internal/locality/locality_test.go:636 @ 06/04/24 11:52:09.548
Choose Distributed Processes
Name | N | Min | Median | Mean | StdDev | Max
==================================================================================
ChooseDistributedProcesses [duration] | 50 | 300µs | 400µs | 400µs | 100µs | 1ms
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
nicmorales9
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few things to double check but the core lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2034
Type of change
Please select one of the options below.
Discussion
Most of the code changes are adjustments for the testing code, to make sure we add some randomness.
Testing
Added additional unit tests and modified them.
Documentation
Follow-up