Refactor systemd unit installation

[jtagcat]

No description provided.

[Foxboron]

While I don't object to the changes it would be nice to get a better description why these changes are needed.

They also seem to change some inconsequential function names for no particular reason?

[jtagcat]

Context: I'm trying to get TPM ssh keys working. Some (mainly spacing changes) are by auto-run gofmt and me reading the code.

fix slog formatting is because slog doesn't use fmt (see https://pkg.go.dev/log/slog)

For the other commit, I went looking why my user unit exec pointed to $HOME/go/bin, not $HOME/go/bin/ssh-tpm-agent. In the end, I have no idea why, it seems fine, when trying again.

The systemd check was wrong: you can run systemd without the .config/systemd/user directory existing.

The function name changes are for readability, in most cases Get* is not needed, as it is assumed. https://www.youtube.com/watch?v=-J3wNP6u5YU might give a fair-enough longer explanation. You are the maintainer, feel free to drop the name changes.

Any other changes here are pure refactor, iirc avoiding copy-pasta code in the install functions.

[Foxboron]

For the other commit, I went looking why my user unit exec pointed to $HOME/go/bin, not $HOME/go/bin/ssh-tpm-agent. In the end, I have no idea why, it seems fine, when trying again.

This change fixed it probably; e1ecab3

[jtagcat]

For the other commit, I went looking why my user unit exec pointed to $HOME/go/bin, not $HOME/go/bin/ssh-tpm-agent. In the end, I have no idea why, it seems fine, when trying again.

This change fixed it probably; e1ecab3

aha, yep the problem was that I installed 0.1.0 with go install ...@latest (or AUR), since release candidates are not actual releases. I created the unit before I upgraded to 1.0.0-rc2.

[Foxboron]

aha, yep the problem was that I installed 0.1.0 with go install ...@latest (or AUR), since release candidates are not actual releases. I created the unit before I upgraded to 1.0.0-rc2.

Ohh, I was not aware that go would be that clever and ignore the tag.

[Foxboron]

Suggested change

	@TEMPLATE_BINARY=/usr/bin/ssh-tpm-agent DESTDIR=$(DESTDIR) PREFIX=$(PREFIX) bin/ssh-tpm-agent --install-user-units --install-system
	@TEMPLATE_BINARY=$(BINDIR)/ssh-tpm-agent DESTDIR=$(DESTDIR) PREFIX=$(PREFIX) bin/ssh-tpm-agent --install-user-units --install-system

[Foxboron]

Generally for the future, it would be better to have the descriptions explaining "why" in the commits themselves, then we won't be at the mercy of github to contexualize the commits :)

Other then that it's fine. I can amend the BINDIR change.

[Foxboron]

Merged with 7f5985f