Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA keylength, keys directory permissions, remove pause module #12

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

jeanmonet
Copy link
Contributor

Referring to the following opened issues:

Proposals:

  • create variable dkim_rsa_keylen that allows to set a custom length for the generated RSA key
  • use debug module instead of pause to print public key/DNS TXT record to screen
  • ensure ownership by opendkim (or group set in dkim_group variable) of the ../keys/ directory, in order for opendkim to be able to read the private key file

Copy link
Contributor

@foxycode foxycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late answer. Will merge after you update. Thanks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
defaults/main.yml Outdated Show resolved Hide resolved
tasks/dns_records.yml Outdated Show resolved Hide resolved
@jeanmonet
Copy link
Contributor Author

jeanmonet commented Apr 15, 2021

@foxycode Thanks for review. Before I update the PR, would you mind re-checking your suggestion on defaults/main.yml ? I think a default value for dkim_rsa_keylen would be needed to pass it to tasks/opendkim_keys.yml explicitly if it's not set by the user.

@foxycode
Copy link
Contributor

Great, thanks :)

@foxycode foxycode merged commit f17caea into FoxyRoles:master Apr 20, 2021
@jeanmonet jeanmonet deleted the rsa_keylen branch April 21, 2021 06:01
chas0amx pushed a commit to chas0amx/ansible-dkim that referenced this pull request Jun 16, 2024
…oles#12)

Make RSA key length configurable, set permissions, remove pause module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants