Preferences: avoid non-default constructor

FreDiabetics · May 17, 2019 · 04c84ca · 04c84ca
1 parent 6b8f790
commit 04c84ca
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/app/src/main/java/com/eveningoutpost/dexdrip/utils/Preferences.java b/app/src/main/java/com/eveningoutpost/dexdrip/utils/Preferences.java
@@ -102,7 +102,7 @@
 import java.util.List;
 import java.util.Map;
 
-import lombok.RequiredArgsConstructor;
+import lombok.Setter;
 
 /**
  * A {@link PreferenceActivity} that presents a set of application settings. On
@@ -134,7 +134,8 @@ public class Preferences extends BasePreferenceActivity implements SearchPrefere
 
 
     private void refreshFragments() {
-        this.preferenceFragment = new AllPrefsFragment(this);
+        this.preferenceFragment = new AllPrefsFragment();
+        this.preferenceFragment.setParent(this);
         pFragment = this.preferenceFragment;
         getFragmentManager().beginTransaction().replace(android.R.id.content,
                 this.preferenceFragment).commit();
@@ -723,10 +724,11 @@ private static void bindPreferenceSummaryToValueAndEnsureNumeric(Preference pref
     }
 
 
-    @RequiredArgsConstructor
+
     public static class AllPrefsFragment extends PreferenceFragment {
 
-        final Preferences parent;
+        @Setter
+        Preferences parent;
         SharedPreferences prefs;
         SearchConfiguration searchConfiguration;
 
@@ -2000,7 +2002,7 @@ public void run() {
                                 JoH.runOnUiThread(new Runnable() {
                                     @Override
                                     public void run() {
-                                        parent.refreshFragments();
+                                        if (parent != null) parent.refreshFragments();
                                     }
                                 });
                             } catch (Exception e) {