Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the port in FreeBSD (support for eventfd, and some more fixes) #4

Open
jiixyj opened this issue Nov 9, 2019 · 7 comments
Open

Comments

@jiixyj
Copy link
Contributor

jiixyj commented Nov 9, 2019

Thank you for maintaining the port in FreeBSD!

Since the 0.0.20190311 version in ports I've implemented some features and fixes (https://github.com/jiixyj/epoll-shim):

  • eventfd support (needed for pipewire)
  • support for more than 32 timerfds per process (by using kqueue timers if possible)
  • removal of the poll fd hack
  • added a pkg-config file (modeled after the one in the port, thanks!)
  • removed the old Makefile, replaced with a CMake build system. Hopefully the library should be easier to package and use now.

I've tried to update the ports files here: https://github.com/jiixyj/freebsd-ports/tree/libepoll-shim/devel/libepoll-shim . Feel free to take/adapt them! I could remove some hacks needed for the old Makefile and replace them by simply using "USES= cmake".

Also, I'd be very happy if someone could point me to some guides/documentation on how to use Wayland on FreeBSD (preferably sway). Currently I'm using i3 on Xorg and libinput is the only library I can really test epoll-shim with.

Lastly, please let me know if there are any bugs/features or if I can make the library easier to package!

@valpackett
Copy link

guides/documentation on how to use Wayland on FreeBSD

I have something sort of like a guide: https://unrelenting.technology/kb/FreeBSDDesktop

@jiixyj
Copy link
Contributor Author

jiixyj commented Nov 9, 2019

Thanks for the pointers! I see you already updated the port files to a newer version, so I didn't need to duplicate the work. At least I got to play around with the ports system a bit :)

@zeising
Copy link
Member

zeising commented Nov 9, 2019

Is there any chance you can create a pull request towards this branch, with your changes?

@jiixyj jiixyj mentioned this issue Nov 9, 2019
@valpackett
Copy link

Should the fork even exist anymore? Why?

@jiixyj
Copy link
Contributor Author

jiixyj commented Nov 10, 2019

I've opened a PR here: #5

A minor road block was a failing timer test on FreeBSD 11.2 because of: https://svnweb.freebsd.org/base?view=revision&revision=336761

This is fixed in FreeBSD 11.3 and I've updated the CI image in .cirrus.yml.

@grembo
Copy link
Contributor

grembo commented Jan 25, 2020

@johalun Can we change the port to use @jiixyj's repo + cmake etc.? Or can we at least fork from it? I just spent two hours debugging a problem until I realized that it was a libepoll-shim problem that's already resolved in @jiixyj current version. Thanks!

@grembo
Copy link
Contributor

grembo commented Feb 12, 2020

@zeising Same here, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants