-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 20191109 #5
Open
jiixyj
wants to merge
81
commits into
FreeBSDDesktop:master
Choose a base branch
from
jiixyj:update-20191109
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in is_not_yet_connected_stream_socket()
(cherry picked from commit 083ef491cfd5a774d7d3fda39876edaa035ef668)
…(), not epoll_shim_close()
On FreeBSD 11.2, the many-timers test fails because of: https://svnweb.freebsd.org/base?view=revision&revision=336761 Since FreeBSD 11.2 is not longer supported, I guess it's OK to update to 11.3. This uses the image_family keys as described here: https://github.com/cirruslabs/cirrus-ci-docs/blob/master/docs/guide/FreeBSD.md For FreeBSD 11.3, one has to specify "freebsd-11-3-snap" since "freebsd-11-3" does not boot.
@zeising You might want to close this now. What is the future process to contributing to this project? Open a pull request here? Open one upstream (it targets FreeBSD)? Then open a bug in FreeBSD bugzilla on top, to update the port skeleton? Maybe you could modify README.md to give contributors a hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings this repo up-to-date with the current master from https://github.com/jiixyj/epoll-shim/ .
Related issue with more comments: #4