Creae meson build system #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add meson.build and try to convert this to use Meson rather than CMake as a build system. This is still experimental. Get a .pc file as part of the Meson build system.
Switch name from libepoll-shim to epoll-shim, to match the name used in the CMake build.
Use both_libraries to build both shared and static libraries. The libraries are built from the same metadata, so instead of having separate build instructions, just merge it and build both types of libraries from the same information.
Update how we generate pkg-config files. Use the library object as a base for the .pc file, this gives us some information for the .pc file for free. Add URL. Update include directory since we install headers in a subdir (this was broken before) Require a newver version of meson that includes support for this way of generating .pc files.
Fiddle with build options, use a default warning level, and a default build type of debugoptimized.
Change the CI to run the meson build as well as the make build.
First pass at using the Symbol map to hide symbols. This is a little clunky in meson, since there's no built in support for this yet. What we do is we define the path to the version map, and the linker flags to use it, and then test if the compiler is OK with this. If it is, then all is good, otherwise, we abort and complain. The linker flags are also added to to library build step.
Don't use -fvisibility=hidden to hide *all* symbols. Then we can't link against this library.
Fix the Cflags include dir in .pc file, headers are installed in
${includedir}/libepoll-shim, not ${includedir}/epoll-shim.
Move -Werror to default options so that it can be overridden if needed. Remove our special flags, -Wall -Wextra are added by default, no need to add them ourselves.
Remove make build from CI, this should have been done in 884d235.
Format default_options better, to avoid overly long lines.
jiixyj
added a commit
to jiixyj/epoll-shim-1
that referenced
this pull request
Nov 9, 2019
… in is_not_yet_connected_stream_socket()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a meson build system..