Interpret Null UserIdentityToken as Anonymous during ActivateSession #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPC-UA specification Part 4, 5.6.3 specifies that a Null or empty user token shall always be interpreted as anonymous. Add a test for this case and a fix to properly handle it.
|
could not find a better place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPC-UA specification Part 4, 5.6.3 specifies that a Null or empty user token shall always be interpreted as anonymous. Add a test for this case and a fix to properly handle it.
I have a client that uses a Null token when connecting that is refused by the server. I don't know if the empty case would be different.
I'm not sure if the fix should remain in
internal_session.pyor move somewhere in the parser or accepted tokens, feel free to point me toward a more suitable place if needed.