EventFilter: handle objects in EventTypes #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroeder-
commented
Jun 6, 2022
| browse_path = [] | ||
| if parent_variable: | ||
| browse_path.append(await parent_variable.read_browse_name()) | ||
| async def _append_new_attribute_to_select_clauses(attribute: "Node", select_clauses: List[ua.SimpleAttributeOperand], already_selected: Dict[str, str], browse_path: List[ua.QualifiedName]): | ||
| browse_path.append(await attribute.read_browse_name()) | ||
| string_path = '/'.join(map(str, browse_path)) | ||
| if string_path not in already_selected: | ||
| already_selected[string_path] = string_path |
There was a problem hiding this comment.
I guess because filters work on browse_names not on nodeids?
deeTEEcee
reviewed
Jun 6, 2022
| await _append_new_attribute_to_select_clauses(property, select_clauses, already_selected, [*browse_path]) | ||
| for variable in await child.get_variables(): | ||
| await _append_new_attribute_to_select_clauses(variable, select_clauses, already_selected, [*browse_path]) | ||
| await _select_clause_from_childs(variable, select_clauses, already_selected, browse_path + [await variable.read_browse_name()]) |
There was a problem hiding this comment.
Question: Will "variables" actually have nested objects or do they only contain properties? (Just to make sure I have the definition right, properties are leaf nodes that hold values)
There was a problem hiding this comment.
Porperties as of spec shouldn't contain child nodes. A non conforming server could do this.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a EventType has a object as child, add it's variables and properties to the eventfilter. Also handles variables that contain nested variables or objects.
Fixes #905