Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK+ 2 compatibility #276

Merged
merged 18 commits into from
Jul 17, 2014
Merged

GTK+ 2 compatibility #276

merged 18 commits into from
Jul 17, 2014

Conversation

repzilon
Copy link
Contributor

There were two problems when I tried to use Remmina on GTK+2:

  • The Quick Connect bar was taking too much space, like half the height of the main window
  • A segmentation fault right after the mouse pointer changes in a RDP session

The commit 6e4a0b6 contains the fix. I am a newbie with git and Github (git is still alien to me), this pull request is too large. Although you may be interested to some other changes like:

  • a679e58 : Fixed Gentoo QA Notice in desktop file
  • 0009c9f : Recompressed icons. Also removed executable bit to some icons.
  • d3d2b41 : Corrected compile warnings

repzilon and others added 18 commits March 15, 2014 00:09
… to make it compile with FreeRDP 1.1.0_beta1_p20130710
 * QA Notice: This package installs one or more .desktop files that do not
 * pass validation.
 *
 *      /usr/share/applications/remmina.desktop: warning: key "OnlyShowIn" in group "Desktop Action Profile" is deprecated
 *      /usr/share/applications/remmina.desktop: warning: key "OnlyShowIn" in group "Desktop Action Tray" is deprecated
 *
* plugin-rdp: convert to new unicode convertion api
* plugin-rdp: minor fixes
(cherry picked from commit 74db2bb)

Conflicts:
	remmina-plugins/rdp/rdp_event.c
	remmina-plugins/rdp/rdp_graphics.c
(cherry picked from commit 108b8cf)
(cherry picked from commit 862e383)
(cherry picked from commit e354cd2)
	* RDP mouse cursor image reference count is no longer decremented. It probably introduces a memory leak, but decrementing the reference count causes a segfault.
	* The Quick Connect bar of the main window no longer take half of the window height.
	* The protocol selector of the Quick Connect bar looks like a regular drop-down list on QtCurve theme.
@antenore
Copy link
Member

Testing

antenore added a commit that referenced this pull request Jul 17, 2014
@antenore antenore merged commit 8ebb325 into FreeRDP:master Jul 17, 2014
@antenore antenore added this to the v1.0.1 milestone Aug 20, 2014
antenore added a commit that referenced this pull request Jul 10, 2015
antenore added a commit that referenced this pull request Jul 10, 2015
antenore added a commit that referenced this pull request Jul 10, 2015
jbicha pushed a commit to jbicha/Remmina that referenced this pull request Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants