Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression introduced by 190ea2f98ab0443b8a05f70c79e2af037f9fca94 #617

Merged
merged 1 commit into from
Jul 17, 2015
Merged

fix regression introduced by 190ea2f98ab0443b8a05f70c79e2af037f9fca94 #617

merged 1 commit into from
Jul 17, 2015

Conversation

zfil
Copy link
Contributor

@zfil zfil commented Jul 17, 2015

See issue #616

@giox069
Copy link
Contributor

giox069 commented Jul 17, 2015

@ZFILL and @lanoxx, unfortunately we have no means (and no time) to check in advance what will happen to the PPA before committing/merging here on github.
So my idea is to merge this fix and see tomorrow what it will happen to the PPA. @antenore, do you agree ?

@antenore
Copy link
Member

Yes, but I'm rolling back the pull request as I'm not sure tomorrow I'll have time to revert it again.
It's really weird what happens by the way. I cannot get why @bindir@ is not expanded...

@antenore
Copy link
Member

Ah! Sorry didn't read carefully...

Yes! Also because this is quite the same modification I proposed to @lanoxx

So, let's try, but as Giovanni said we cannot guarantee it'll work before tomorrow (but I'm confident)

antenore added a commit that referenced this pull request Jul 17, 2015
@antenore antenore merged commit 5590b57 into FreeRDP:next Jul 17, 2015
@antenore
Copy link
Member

That's it

@giox069
Copy link
Contributor

giox069 commented Jul 17, 2015

Thank you. Let's see what will happen to the PPA tomorrow :)

@giox069
Copy link
Contributor

giox069 commented Jul 17, 2015

And thank you to @zfil and @lanoxx too :)

@antenore
Copy link
Member

Yes, thanks to both :-P !

akallabeth pushed a commit to akallabeth/Remmina that referenced this pull request Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants