MISRA Compliance Update #121
Merged
+48
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2022 21:39
SDE. Put inline supression for a comparison related to the SIZE_MAX macro. Want to get clarification about the line before putting a change in.
jasonpcarroll
approved these changes
Jul 19, 2022
jasonpcarroll
approved these changes
Jul 22, 2022
jasonpcarroll
previously approved these changes
Jul 22, 2022
…ion in source file to match new formatting
…le, and expanding on a message
AniruddhaKanhere
requested changes
Aug 3, 2022
Remove extra set of square brackets Co-authored-by: Aniruddha Kanhere <[email protected]>
added 5 commits
August 11, 2022 22:07
…o rule exceptions from the misra.config due to the change
violation. It was flagged because it believed that the if statement comparison was invariant. This could be proven as a bug by assigning the variable a value larger than the comparison, and then still receiving the violation. A logic change has been made to get around this, but it now fails CBMC proofs. Trying a different if statement to see if this passes checks.
skipOneHexEscape() I believe proof was found that shows the MISRA violation is a false flag. Due to this I believe that this should simply receive a suppression and the focus should be on the CBMC proofs.
ravibhagavandas
approved these changes
Aug 16, 2022
aggarg
approved these changes
Aug 17, 2022
AniruddhaKanhere
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put inline suppression for a comparison related to the SIZE_MAX macro.